فهرست منبع

Review fix-ups: account menu dropdown behaviour and card padding

Two integration defects from the completion review. (1) The account cluster used spry's .menu class - the always-expanded vertical menu variant - which forced the Account submenu permanently open and bulky; it now uses .nav like the Work/Library/Admin menus (headless-verified: submenu is absolute/hidden/opacity-0 at rest, identical to the others). (2) spry's .card carries no padding of its own (padding belongs to .card-header/-body/-footer children) and this app puts content directly in .card, so text sat hard against the card edges; .card now pads with the framework's own --spry-card-padding, and cards built from header/body/footer children keep the framework chrome via a padding reset (:has) - chosen over negative-margin bleed after a browser probe showed margins break the header/footer full-width chrome. Bare-card gap 21px verified headless. Bundles green: pages 129, goalui 142, t4lists 27, t9library 39, theme 38, advisor_fix 47.
saddle-ClankerSaddle 1 روز پیش
والد
کامیت
dbded1abc8
2فایلهای تغییر یافته به همراه27 افزوده شده و 1 حذف شده
  1. 26 0
      src/pages/app.css
  2. 1 1
      src/pages/main.html

+ 26 - 0
src/pages/app.css

@@ -1514,3 +1514,29 @@ td .truncate.repo-url {
     background: var(--spry-bg-inset);
     color: var(--spry-fg-muted);
 }
+
+/* ==========================================================================
+   Goal 41 review fix-ups (post-T11 review feedback)
+   Two integration defects the review caught: cards had no breathing room
+   (spry's .card carries no padding of its own - padding belongs to
+   .card-header/-body/-footer, and this app puts content directly in .card),
+   and the account menu used .menu, which is spry's ALWAYS-EXPANDED
+   vertical menu variant - it forced the submenu open and bulky. Cards now
+   carry the framework's own --spry-card-padding; the account menu uses
+   .nav like every other dropdown (markup fix in main.html).
+   ========================================================================== */
+
+/* Default card padding: the framework's own card rhythm. Cards built
+   from the header/body/footer children keep the framework's chrome
+   (those children self-pad the same amount, so the parent's padding is
+   removed for them); every other card gets the padding directly.
+   Chosen over negative-margin bleed after a headless-browser probe
+   showed margins break the header/footer full-width chrome. */
+.card {
+    padding: var(--spry-card-padding);
+}
+.card:has(> .card-header),
+.card:has(> .card-body),
+.card:has(> .card-footer) {
+    padding: 0;
+}

+ 1 - 1
src/pages/main.html

@@ -60,7 +60,7 @@
             </ul>
             <!-- spry:nav-end -->
             <span class="nav-auth">
-                <ul class="menu" role="menu">
+                <ul class="nav" role="menu">
                     <li class="has-submenu">
                         <a href="/profile">Account</a>
                         <ul class="submenu" role="menu">